fix(wasm): add windowsHide to spawnSync re-exec to suppress terminal popup on Windows#521
Open
JirA44 wants to merge 1 commit into
Open
fix(wasm): add windowsHide to spawnSync re-exec to suppress terminal popup on Windows#521JirA44 wants to merge 1 commit into
JirA44 wants to merge 1 commit into
Conversation
…popup on Windows The spawnSync call that re-execs Node with --liftoff-only was missing windowsHide: true. When the MCP server starts without a console (spawned with windowsHide: true from the host), the re-exec child inherits no console and Windows opens a new one instead, causing the visible terminal flash on every codegraph invocation. Fixes colbymchenry#510
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
spawnSynccall inrelaunchWithWasmRuntimeFlagsIfNeededwas missingwindowsHide: true.When the MCP server is launched by a host (e.g. VS Code) it is spawned with
windowsHide: true, so it has no attached console. When the server then re-execs itself with--liftoff-onlyviaspawnSync— withoutwindowsHide: true— Windows finds no existing console to inherit and opens a new one, producing the visible terminal flash on every save/MCP invocation.The fix is one line: add
windowsHide: trueto thespawnSyncoptions, matching the flag already present on the initial daemon spawn insrc/mcp/index.ts.Fixes #510