BUG: Avoid stackoverflows and memory issues in zod while processing large strings#3880
Closed
klh wants to merge 3 commits intocolinhacks:mainfrom
Closed
BUG: Avoid stackoverflows and memory issues in zod while processing large strings#3880klh wants to merge 3 commits intocolinhacks:mainfrom
klh wants to merge 3 commits intocolinhacks:mainfrom
Conversation
When processing large strings zod will cause overflows and inefficient handling of items - especially base64 strings can be large at times
✅ Deploy Preview for guileless-rolypoly-866f8a ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
klh
changed the title
Author
|
bump on this? |
Owner
|
This is addressed in #4386. With those changes it can handle strings up to the limits of Node.js string length so I believe these concerns are fully addressed 👍 It was a matter of optimizing the regex. Thanks for the PR though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit will:
NOTES: there are sure to be other cases when handling large strings that can benefit from this, but i think maintainers should decide where and when.