Add healthcheck summary & list bad devices commands to lava-rs example#18
Merged
Merged
Conversation
obbardc
force-pushed
the
wip/obbardc/healthcheck
branch
3 times, most recently
from
d3db768 to
83b18ff
Compare
obbardc
force-pushed
the
wip/obbardc/healthcheck
branch
from
83b18ff to
a79af23
Compare
There was a problem hiding this comment.
Pull request overview
Adds new CLI subcommands to the lava-api lava-rs example to help operators summarize device healthcheck outcomes and quickly list devices in a bad state.
Changes:
- Add
bad-devicescommand to list bad devices and (when available) show how long since the latest failed healthcheck. - Add
healthcheckscommand to summarize passed/failed healthchecks for a specific device (optionally listing failed job IDs). - Introduce a small duration-formatting helper for “since” output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add a `healthchecks` subcommand to the lava-rs tool to summarise healthcheck job results for a specific device. The command scans finished jobs, filters healthcheck jobs for the requested device and reports passed/failed totals as well as expressing the total as a percentage. It can optionally prints the job IDs of failed healthcheck jobs. This makes it easier to quickly inspect a device's healthcheck history. Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
obbardc
force-pushed
the
wip/obbardc/healthcheck
branch
from
a79af23 to
bd774f3
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
obbardc
force-pushed
the
wip/obbardc/healthcheck
branch
from
bd774f3 to
1ed0156
Compare
Add a `bad-devices` subcommand to the lava-rs tool to list devices currently marked with bad health and how long the device has been bad for. The list is sorted by how long the device has been bad for - oldest first. For each bad device print the hostname, worker host, tags and the device description. Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
obbardc
force-pushed
the
wip/obbardc/healthcheck
branch
from
1ed0156 to
49a7e5e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.