Skip to content

DRYD-1904: Object Record > Anthro > Add Material/technique description#326

Merged
spirosdi merged 1 commit intodevelopfrom
feature/dryd-1904
Dec 10, 2025
Merged

DRYD-1904: Object Record > Anthro > Add Material/technique description#326
spirosdi merged 1 commit intodevelopfrom
feature/dryd-1904

Conversation

@spirosdi
Copy link
Copy Markdown
Contributor

@spirosdi spirosdi commented Dec 9, 2025

What does this do?
It adds the materialTechniqueDescription field in the anthro tenant.

Why are we doing this? (with JIRA link)
https://collectionspace.atlassian.net/browse/DRYD-1904

How should this be tested? Do these changes have associated tests?
Please check the collectionspace/cspace-ui-plugin-profile-anthro.js#38

Dependencies for merging? Releasing to production?
No dependencies. It is a dependency of collectionspace/cspace-ui-plugin-profile-anthro.js#38

Has the application documentation been updated for these changes?
no need for update

Did someone actually run this code to verify it works?
@spirosdi ran it locally

Copy link
Copy Markdown
Contributor

@mikejritter mikejritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally and was able to create an object with a materialTechniqueDescription + see it in the db.

It's unfortunate that the fineart-collectionobject extension has additional fields, otherwise I'd say that would be nice to use. I wonder if it's worth looking at some of the extensions and decomposing them so they're less about the use (fineart/anthro) and more about what they're doing (material co extensions). Probably a discussion for another time though.

@spirosdi
Copy link
Copy Markdown
Contributor Author

Built locally and was able to create an object with a materialTechniqueDescription + see it in the db.

It's unfortunate that the fineart-collectionobject extension has additional fields, otherwise I'd say that would be nice to use. I wonder if it's worth looking at some of the extensions and decomposing them so they're less about the use (fineart/anthro) and more about what they're doing (material co extensions). Probably a discussion for another time though.

Makes total sense, I was also wondering about. I created this follow-up task to investigate this: https://collectionspace.atlassian.net/browse/DRYD-1986

@spirosdi spirosdi merged commit 0f44f26 into develop Dec 10, 2025
@spirosdi spirosdi deleted the feature/dryd-1904 branch December 10, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants