Conversation
mikejritter
approved these changes
Feb 26, 2026
Contributor
mikejritter
left a comment
There was a problem hiding this comment.
Changes look good, I just haven't had a chance to check yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
It removes any query parameters from
fileURLto create the file name when downlading.Why are we doing this? (with JIRA link)
This is to support importing presigned urls (such as https://spiros-demo-bucket.s3.dualstack.eu-north-1.amazonaws.com/866-200x300%20copy%202.jpg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20260226T094443Z&X-Amz-SignedHeaders=host&X-Amz-Expires=604799&X-Amz-Credential=AKIARVCQFYMS7XR6IIU6%2F20260226%2Feu-north-1%2Fs3%2Faws4_request&X-Amz-Signature=79c91fcd8fdead2a48d2e840ce657c725f1d96d8bb4d8a45bb97ee923478de29) that include a lot of query parameters resulting to a very long url. Eventually leading to
(File name too long)exception.How should this be tested? Do these changes have associated tests?
Dependencies for merging? Releasing to production?
No dependencies
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
@spirosdi ran it locally
Have any new security vulnerabilities been handled?
N/A