Migrate authentication from xsd to classes#519
Merged
mikejritter merged 4 commits intoApr 9, 2026
Merged
Conversation
4a73a3c to
cec748f
Compare
mikejritter
added a commit
to mikejritter/services
that referenced
this pull request
Apr 14, 2026
* Migrate authentication from xsd to classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2074
This migrates both the JPA entities and JAXB models as we are not migrating to jakarta persistence yet, so using the plugin for code gen is no longer available afaik (you can do either all javax or all jakarta).
JSpecify has been added in order to start to help understand what can/cannot be null. At the moment, I only added NonNull to the List getters in order to reflect previous behavior.
How should this be tested? Do these changes have associated tests?
diff)git diff --no-index <(cat diff/org/collectionspace/**/*.java) <(cat src/main/java/org/collectionspace/**/*.java)mvn clean compileshould pass (might have dependencies which need to be compiled as well)Dependencies for merging? Releasing to production?
Still more modules to migrate + other javax to jakarta import migration before compilation will be possible.
There's also an old Aspect which we should look at once the migrations are finished (JaxbXMLGregorianCalendarMarshal).
In this module specifically, there are some test resources and properties that can be double checked for removal once more of the migration is complete. This could also be done against dev.
Has the application documentation been updated for these changes?
n/a
Did someone actually run this code to verify it works?
@mikejritter has been testing locally