Skip to content

Migrate authentication from xsd to classes#519

Merged
mikejritter merged 4 commits into
collectionspace:upgrade/dryd-1633-core-updatesfrom
mikejritter:upgrade/dryd-2074-authentication
Apr 9, 2026
Merged

Migrate authentication from xsd to classes#519
mikejritter merged 4 commits into
collectionspace:upgrade/dryd-1633-core-updatesfrom
mikejritter:upgrade/dryd-2074-authentication

Conversation

@mikejritter
Copy link
Copy Markdown
Contributor

@mikejritter mikejritter commented Apr 6, 2026

What does this do?

  • Removes hyperjaxb plugin from the authentication jaxb module
  • Create classes for what was previously schema generated
  • Add jspecify for some null safety

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2074

This migrates both the JPA entities and JAXB models as we are not migrating to jakarta persistence yet, so using the plugin for code gen is no longer available afaik (you can do either all javax or all jakarta).

JSpecify has been added in order to start to help understand what can/cannot be null. At the moment, I only added NonNull to the List getters in order to reflect previous behavior.

How should this be tested? Do these changes have associated tests?

  • On dev:
    • Compile the authentication/jaxb module
    • copy the generated sources to a separate directory (e.g. diff)
  • switch to this branch
    • compare the old generated classes to the new classes, e.g. git diff --no-index <(cat diff/org/collectionspace/**/*.java) <(cat src/main/java/org/collectionspace/**/*.java)
    • mvn clean compile should pass (might have dependencies which need to be compiled as well)

Dependencies for merging? Releasing to production?
Still more modules to migrate + other javax to jakarta import migration before compilation will be possible.

There's also an old Aspect which we should look at once the migrations are finished (JaxbXMLGregorianCalendarMarshal).

In this module specifically, there are some test resources and properties that can be double checked for removal once more of the migration is complete. This could also be done against dev.

Has the application documentation been updated for these changes?
n/a

Did someone actually run this code to verify it works?
@mikejritter has been testing locally

@mikejritter mikejritter force-pushed the upgrade/dryd-2074-authentication branch from 4a73a3c to cec748f Compare April 6, 2026 22:45
@mikejritter mikejritter marked this pull request as ready for review April 7, 2026 21:20
@mikejritter mikejritter merged commit 3c909e6 into collectionspace:upgrade/dryd-1633-core-updates Apr 9, 2026
@mikejritter mikejritter deleted the upgrade/dryd-2074-authentication branch April 9, 2026 17:13
mikejritter added a commit to mikejritter/services that referenced this pull request Apr 14, 2026
* Migrate authentication from xsd to classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant