DRYD-2100: Configure legacy trash implementation#531
Merged
mikejritter merged 1 commit intoMay 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds configuration to use Nuxeo's legacy trash implemenation
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2100
The new TrashService and implementation are not accounted for anywhere in our codebase, so trashed documents end up coming back in API responses and other places. Before we potentially migrate to the new implementation, we can add some configuration to enable the legacy implementation which allows us to make fewer changes at the moment.
How should this be tested? Do these changes have associated tests?
Dependencies for merging? Releasing to production?
We should move away from the 9.10-HF30 folder for configuration, though we have another ticket to handle build changes already.
Has the application documentation been updated for these changes?
No. This is something that we should look at adding to the developer docs.
Did someone actually run this code to verify it works?
@mikejritter has been testing locally
Have any new security vulnerabilities been handled?
n/a