Persist converted pdf and publish it as pdf/dump.pdf and @@pdf #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisto
reviewed
May 12, 2017
Member
|
@tkimnguyen @vangheem who can we ask for a pull request review here? Anybody who could merge and do a release? If you don't have time, you could also consider granting us permissions to do a release on pypi (my username is timo). |
Member
|
FYI: We need this for an Angular 2 client that just uses c.documentviewer internally to convert other formats to PDF. Our font-end document viewer can just render PDF. |
vangheem
approved these changes
May 12, 2017
Member
|
@tisto I've added you as a maintainer on pypi. Feel free to merge when you feel good about the current question of browser view name. |
jaroel
changed the title
Member
|
@vangheem thank you! |
Member
|
@jaroel we might want to merge this feature into the Plone 5 version of c.documentviewer. Though, we don't need that for our current project... |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows uploading a docx and displaying a pdf version of it using pdf.js