fix: add type hints for encoding parameter in parser_tools#1399
Merged
stevepiercy merged 6 commits intoMay 23, 2026
Conversation
added 2 commits
May 22, 2026 23:45
Added 'str' type hint to the encoding parameter in from_unicode, to_unicode, and data_encode functions. Used Claude (claude-sonnet-4-6) to identify untyped parameters and suggest the fix. Reviewed and validated all changes manually.
angatha
previously approved these changes
May 23, 2026
stevepiercy
requested changes
May 23, 2026
Member
stevepiercy
left a comment
There was a problem hiding this comment.
This is good.
My suggestion adds markup to show that it's an inline literal. With that change, it can be merged.
Thank you!
Member
|
@cybs-joe would you please edit the description from |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'str' type hint to the encoding parameter in from_unicode, to_unicode, and data_encode functions.
Used Claude (claude-sonnet-4-6) to identify untyped parameters and suggest the fix. Reviewed and validated all changes manually.
Refs issue 938
Description
Added
strtype hint to theencodingparameter infrom_unicode,to_unicode, anddata_encodeinsrc/icalendar/parser_tools.py.Checklist
/news, following the instructions in Change log entry format.Additional information
Upload screenshots, videos, links to documentation, or any other relevant information.
📚 Documentation preview 📚: https://icalendar--1399.org.readthedocs.build/