Fix condition evaluation and user_answers when root_key is used#23
Merged
Conversation
ericof
approved these changes
May 22, 2026
ericof
pushed a commit
that referenced
this pull request
May 22, 2026
ericof
pushed a commit
that referenced
this pull request
May 22, 2026
ericof
pushed a commit
that referenced
this pull request
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug in
Form.is_activeandForm.user_answerswhere they were not aware ofroot_keynesting.When a
root_keyis defined (likecookiecutterincookieplone), all answers are nested under that key.The engine was looking for answers at the top level, causing all conditions to fail and
user_answersto be empty or raiseKeyError.This PR:
is_activelook insideroot_keyfor gating answers.user_answersretrieve values from the nested dict.BaseRenderer.renderto automatically record un-nestedinitial_answersunder theroot_keyif one exists.tests/form/test_form_root_key.py.This is required for conditional questions in
cookieploneto work properly.