feat: add MCP tool annotations for read-only vs destructive operations#53
Merged
bobby-smedley merged 4 commits intomainfrom Apr 14, 2026
Merged
feat: add MCP tool annotations for read-only vs destructive operations#53bobby-smedley merged 4 commits intomainfrom
bobby-smedley merged 4 commits intomainfrom
Conversation
MieszkoWasniowski
previously approved these changes
Apr 14, 2026
| package chip | ||
|
|
||
| // Ptr returns a pointer to the given value. | ||
| func Ptr[T any](v T) *T { return &v } |
Contributor
There was a problem hiding this comment.
Maybe it's time to bump go to 1.26.x, it has solution for that exact problem. Instead of chip.Ptr(true), you could just write new(true).
MieszkoWasniowski
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add MCP tool annotations (per spec 2025-03-26+) to all 26 CHIP tools declaring whether each operation is read-only or destructive. This enables MCP clients to enforce human-in-the-loop approval for write operations.
Changes:
Annotations *mcp.ToolAnnotationsfield tochip.Toolstruct, passed through tomcp.Toolat registrationchip.Ptr[T]helper for pointer-to-value conversions (same pattern ask8s.io/utils/ptr.To)ReadOnlyHint: trueDestructiveHint: trueJIRA reference
DEV-169959
Impact Analysis
Low — additive metadata only. No behavioral changes to existing tools. MCP clients that don't support annotations will ignore them.
Checklist