Handle integer and double parameters passed to algorithms#29
Merged
dylanbstorey merged 1 commit intocolliery-io:mainfrom Mar 17, 2026
Merged
Handle integer and double parameters passed to algorithms#29dylanbstorey merged 1 commit intocolliery-io:mainfrom
dylanbstorey merged 1 commit intocolliery-io:mainfrom
Conversation
Contributor
|
Looks great — really nice refactoring to eliminate the duplicated literal-checking code across all the algorithm call sites! We applied a few minor formatting consistency fixes on our end (tab→space normalization, simplified the int range check for readability, and fixed a duplicate test number). Merging this in, thanks for the contribution! |
dylanbstorey
pushed a commit
that referenced
this pull request
Mar 17, 2026
Contributor
|
thanks for the contribution ! It just went out with 0.3.8 ! (you were also voted for PR of the release - congrats !) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #28, adding support for double and int parameters to the algorithm functions.
Warning: I am no C programmer! I went looking to see why they weren't working and then thought "that can't be too hard to fix". This may be all wrong.
I would have liked to throw errors when parameters are out of range rather than just setting to defaults (for instance,
params.iterations < 1), but the existing code doesn't do that and I haven't figured out how to do it with SQLLite. Maybe something for another PR.