Make view graph calibration a stand-alone estimator module on colmap::Database and add CLI. #3951
Merged
Make view graph calibration a stand-alone estimator module on colmap::Database and add CLI. #3951
Conversation
ahojnnes
approved these changes
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
| if (!problem.HasParameterBlock(&(focals[camera_id]))) continue; | ||
|
|
||
| num_cameras++; | ||
| problem.SetParameterLowerBound(&(focals[camera_id]), 0, 1e-3); |
Contributor
There was a problem hiding this comment.
Extract 1-e3 as a constexpr?
Contributor
There was a problem hiding this comment.
Surprised we are not setting an upper bound.
Contributor
There was a problem hiding this comment.
Also wondering whether it makes sense to bound the parameter using options.min_focal_length_ratio/options.max_focal_length_ratio?
Contributor
Author
There was a problem hiding this comment.
Lets for now extract 1e-3 as a constexpr and keep it as it is, to keep the logic equivalent, as bounding the parameter directly may end up not reverting those diverged focals (not sure if there are any). Maybe this can be resolved by checking whether the focal lengths are exactly at the boundary after optimization, but this needs some studies and goes beyond the scope of this PR.
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
reviewed
Jan 6, 2026
ahojnnes
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes: