Skip to content

Pskel v4#56

Merged
zeriyoshi merged 10 commits intomainfrom
v4
Apr 20, 2026
Merged

Pskel v4#56
zeriyoshi merged 10 commits intomainfrom
v4

Conversation

@zeriyoshi
Copy link
Copy Markdown
Contributor

@zeriyoshi zeriyoshi commented Apr 20, 2026

  • support PIE
  • update license to BSD-3-Clause (follow PHP license changes)
  • update stable LLVM-22 toolchain
  • fix composer.json generation
  • change pskel.sh to symlink
  • fix composite function coverage
  • unify GH Codespaces / Local DevContainer definitions

@zeriyoshi zeriyoshi self-assigned this Apr 20, 2026
Copilot AI review requested due to automatic review settings April 20, 2026 07:44
@zeriyoshi
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Co-authored-by: zeriyoshi <10289597+zeriyoshi@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Pskel skeleton/tooling to align with upstream PHP changes by switching licensing to BSD-3-Clause, refreshing the LLVM toolchain in the dev image, and adjusting the extension initialization flow to better support modern PHP/ext_skel setups.

Changes:

  • Update licensing references and LICENSE contents to BSD-3-Clause.
  • Update Debian-based container setup to use the LLVM 22 apt repository + packages.
  • Enhance pskel init argument parsing (optional vendor) and generate a composer.json for newer PHP versions; add devcontainer post-create symlink for pskel.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pskel.sh Updates init argument handling and composer.json generation for new skeletons.
Dockerfile Switches LLVM installation to v22 using signed apt repo and updates alternatives.
LICENSE Replaces PHP License 3.01 text with BSD-3-Clause text/copyright lines.
README.md Updates displayed license identifier.
README_ja.md Updates displayed license identifier.
ext/.gitignore Adds ignore rules for build artifacts generated under /ext.
ext/.gitkeep Normalizes content/format (keeps uninitialized marker).
.gitattributes Adds export-ignore rules for archive exports.
.devcontainer/devcontainer.json Adds workspace folder + post-create symlink for pskel.
.devcontainer/local/devcontainer.json Adds post-create symlink for pskel.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pskel.sh Outdated
Comment thread pskel.sh
Comment thread pskel.sh Outdated
Co-authored-by: zeriyoshi <10289597+zeriyoshi@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026

@copilot resolve the merge conflicts in this pull request

Resolved and pushed in 79aff63 (with a small follow-up in 51411d7). The PR branch now cleanly merges main with conflicts fixed in pskel.sh. No UI changes in this PR, so there is no screenshot to share.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@zeriyoshi zeriyoshi merged commit 7fa93cd into main Apr 20, 2026
228 of 278 checks passed
@zeriyoshi zeriyoshi deleted the v4 branch April 20, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants