Skip to content

feat: blur company reviews for users w/o access 🚫#487

Merged
ramiAbdou merged 9 commits intocolorstackorg:mainfrom
rafa1510:companies-modal
Sep 24, 2024
Merged

feat: blur company reviews for users w/o access 🚫#487
ramiAbdou merged 9 commits intocolorstackorg:mainfrom
rafa1510:companies-modal

Conversation

@rafa1510
Copy link
Contributor

Description ✏️

Closes #314

Describe what this PR does.

  • When user does not have access to reviews page (checked by utilizing hasReviewsAccess from Check for Reviews Access 🧐  #313), then show a modal to specify why they don't have access to reviews yet
  • image

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ciaracade
Copy link
Contributor

This looks great to me!

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @rafa1510! Tested this locally and it's working perfectly. @ramiAbdou will take a final look but this looks good to ship 🚀

@tomas-salgado tomas-salgado added the Ready ✅ This PR is ready for a final review. label Sep 1, 2024
Copy link
Member

@ramiAbdou ramiAbdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work here, @rafa1510! 🔥 I tested it out and was super smooth!

I initially wanted to restrict the companies page altogether but as I was playing around w/ it, I thought it might've been just a tad too restrictive. So I made an update that instead just blurs out the company review and adds a message there instead of blocking access to the company page altogether. This will allow them to still see who works at a company, etc. Here is an example:

Screenshot 2024-09-24 at 11 35 00 AM

Thanks again to you and @ciaracade for collaborating on this feature! 🙂

cc: @tomas-salgado on the change!

@ramiAbdou ramiAbdou changed the title feat: Show a modal on Companies page when user does not have access feat: blur company reviews for users w/o access 🚫 Sep 24, 2024
@ramiAbdou ramiAbdou merged commit 2f133b9 into colorstackorg:main Sep 24, 2024
@ciaracade
Copy link
Contributor

@ramiAbdou Ateeeeeee. Nice working with you on this feature @rafa1510!

@rafa1510
Copy link
Contributor Author

Likewise @ciaracade! 🤝🫡

iperalta7 pushed a commit to iperalta7/oyster that referenced this pull request Sep 25, 2024
@rafa1510 rafa1510 deleted the companies-modal branch October 9, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready ✅ This PR is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modal on Companies Page 📃

4 participants