Skip to content

chore: remove version from docker compose 🐋#554

Merged
ramiAbdou merged 2 commits intocolorstackorg:mainfrom
wflore19:flo/docker-compose
Oct 7, 2024
Merged

chore: remove version from docker compose 🐋#554
ramiAbdou merged 2 commits intocolorstackorg:mainfrom
wflore19:flo/docker-compose

Conversation

@wflore19
Copy link
Contributor

@wflore19 wflore19 commented Oct 7, 2024

Description ✏️

  • Added my name to the contributors.yml file
  • Removes the 'version' property in the docker-compose.yml file. This property is now officially considered obsolete.

Currently this warning message appears on yarn dx:up

\docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion"

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@tomas-salgado tomas-salgado added the Ready ✅ This PR is ready for a final review. label Oct 7, 2024
@ramiAbdou ramiAbdou changed the title chore: Update Docker Compose file 🐋 & add name to contributor list 📃 chore: remove version from docker-compose.yml 🐋 Oct 7, 2024
@ramiAbdou ramiAbdou changed the title chore: remove version from docker-compose.yml 🐋 chore: remove version from docker compose 🐋 Oct 7, 2024
@ramiAbdou ramiAbdou merged commit 5b75f5a into colorstackorg:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready ✅ This PR is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants