Skip to content

fix: order education history by end date first 🔽#555

Merged
ramiAbdou merged 1 commit intomainfrom
rami/education-bug
Oct 7, 2024
Merged

fix: order education history by end date first 🔽#555
ramiAbdou merged 1 commit intomainfrom
rami/education-bug

Conversation

@ramiAbdou
Copy link
Member

Description ✏️

This PR fixes a bug in which the education history was sorted by start_date then end_date, when it should've been the other way around.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Oct 7, 2024
@ramiAbdou ramiAbdou marked this pull request as ready for review October 7, 2024 18:37
@ramiAbdou ramiAbdou merged commit dfcb97d into main Oct 7, 2024
@ramiAbdou ramiAbdou deleted the rami/education-bug branch October 7, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant