Skip to content

fix: optimistic bookmarking + ai expiration date ❗️#587

Merged
ramiAbdou merged 2 commits intomainfrom
rami/performance
Oct 25, 2024
Merged

fix: optimistic bookmarking + ai expiration date ❗️#587
ramiAbdou merged 2 commits intomainfrom
rami/performance

Conversation

@ramiAbdou
Copy link
Member

Description ✏️

This PR implements optimistic UI for bookmarking an opportunity, and it also fixes a bug where the AI was setting the date to the past since it doesn't know the date.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Oct 25, 2024
@ramiAbdou ramiAbdou marked this pull request as ready for review October 25, 2024 15:31
@ramiAbdou ramiAbdou merged commit 2b9b1e8 into main Oct 25, 2024
@ramiAbdou ramiAbdou deleted the rami/performance branch October 25, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant