Skip to content

fix: nav position on profile tab 👤📱#589

Merged
ramiAbdou merged 3 commits intocolorstackorg:mainfrom
wflore19:flo/stickynav
Dec 5, 2024
Merged

fix: nav position on profile tab 👤📱#589
ramiAbdou merged 3 commits intocolorstackorg:mainfrom
wflore19:flo/stickynav

Conversation

@wflore19
Copy link
Contributor

@wflore19 wflore19 commented Oct 27, 2024

Description ✏️

Changes sidebar nav going out of frame on scroll on profile tab.

before vs after:
nav-profile-sticky

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@wflore19 wflore19 requested a review from ramiAbdou as a code owner October 27, 2024 02:43
@wflore19 wflore19 changed the title fix: nav position on profile tab 👤📱 feat: nav position on profile tab 👤📱 Oct 28, 2024
@tomas-salgado
Copy link
Collaborator

tomas-salgado commented Dec 1, 2024

@wflore19 I'm curious if you still have this issue. This isn't a problem for me, though I'm using Chrome on a Mac. I'll tag this for Rami to look at too, seems like a quick thing

@tomas-salgado tomas-salgado added the Ready ✅ This PR is ready for a final review. label Dec 1, 2024
@wflore19
Copy link
Contributor Author

wflore19 commented Dec 1, 2024

@tomas-salgado Yeah i'm using Chrome on Windows

Screen.Recording.2024-12-01.123428.mp4

@ramiAbdou ramiAbdou changed the title feat: nav position on profile tab 👤📱 fix: nav position on profile tab 👤📱 Dec 5, 2024
@ramiAbdou ramiAbdou merged commit b29b817 into colorstackorg:main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready ✅ This PR is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants