Skip to content

fix: add unique constraint to opportunity's slack message 👖#628

Merged
ramiAbdou merged 1 commit intomainfrom
rami/opportunities
Nov 16, 2024
Merged

fix: add unique constraint to opportunity's slack message 👖#628
ramiAbdou merged 1 commit intomainfrom
rami/opportunities

Conversation

@ramiAbdou
Copy link
Member

Description ✏️

This PR fixes an issue that sometimes duplicates an opportunity from a failed Bull job by adding a unique constraint on (slack_channel_id, slack_message_id).

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Nov 16, 2024
@ramiAbdou ramiAbdou marked this pull request as ready for review November 16, 2024 19:13
@ramiAbdou ramiAbdou merged commit d96bf29 into main Nov 16, 2024
@ramiAbdou ramiAbdou deleted the rami/opportunities branch November 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant