Skip to content

fix: prevent scroll reset for offer modal ❗️#639

Merged
ramiAbdou merged 2 commits intomainfrom
rami/scroll
Nov 20, 2024
Merged

fix: prevent scroll reset for offer modal ❗️#639
ramiAbdou merged 2 commits intomainfrom
rami/scroll

Conversation

@ramiAbdou
Copy link
Member

Description ✏️

This PR prevents the page from resetting the scroll position when navigating from a table, and similarly when clicking the overlay of a modal.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Nov 20, 2024
@ramiAbdou ramiAbdou marked this pull request as ready for review November 20, 2024 18:51
@ramiAbdou ramiAbdou merged commit dbc0940 into main Nov 20, 2024
@ramiAbdou ramiAbdou deleted the rami/scroll branch November 20, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant