Skip to content

fix: scroll issue w/ tables + fixed position of dropdown ❗️#773

Merged
ramiAbdou merged 2 commits intomainfrom
rami/fix
Mar 25, 2025
Merged

fix: scroll issue w/ tables + fixed position of dropdown ❗️#773
ramiAbdou merged 2 commits intomainfrom
rami/fix

Conversation

@ramiAbdou
Copy link
Member

Description ✏️

This PR fixes a bug introduced in #766 where we removed the overflow-auto of the table container (in order to use dropdowns w/ absolute position) but now we can't scroll horizontally either. We reintroduce the overflow-auto but now used fixed positioning for the dropdown with additional JS logic to track the x/y coordinates of the dropdown container.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Mar 25, 2025
@ramiAbdou ramiAbdou marked this pull request as ready for review March 25, 2025 01:32
@ramiAbdou ramiAbdou merged commit d621b71 into main Mar 25, 2025
2 checks passed
@ramiAbdou ramiAbdou deleted the rami/fix branch March 25, 2025 01:36
@ramiAbdou ramiAbdou mentioned this pull request Mar 26, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant