Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description ✏️
This PR:
syncLinkedInProfilesfunction:limit.syncLinkedInProfilesto the Zod schemas for the LinkedIn profile.establishmentandgeocodetypes. It also removes caching from thegetMostRelevantLocationfunction since we already cache the underlying methods that it uses.RateLimiter.doWhenAvailablefunction that decremented the active count in Redis by 1 too much.runActorfunction to be independent of a Zod schema. This ensures that we don't not return the API scraping result when the data doesn't match the input. Also limits theactorId/bodycombination.saveSchoolIfNecessaryfunction to parse the result after it succeeds. It also looks for the address from the Google Places API using theestablishmentproperty.saveCompanyIfNecessaryfunction to parse the result after it succeeds.schools.address_zipcolumn nullable.Type of Change 🐞
Checklist ✅