PR: Fix "from collections import Mapping, MutableMapping" with Python 3.8.#489
Closed
vidakDK wants to merge 1 commit into
Closed
PR: Fix "from collections import Mapping, MutableMapping" with Python 3.8.#489vidakDK wants to merge 1 commit into
vidakDK wants to merge 1 commit into
Conversation
In Python 3.8 from collections import Mutable no longer works, instead from collections.abc import Mutable must be used
Author
|
Ah this needs to work in Python 2 as well? Not sure if worth to fix if Python 2 will be gone in a couple months :) |
Member
|
Hi @vidakDK, I'm not sure yet how long after Python 2 death we will maintain Colour compatibility with it but it will not go instantly. What about using something like that instead: import sys
if sys.version_info[:2] >= (3, 8):
from collections.abc import Mapping, MutableMapping
else:
from collections import Mapping, MutableMapping |
Member
|
Looking at this one and seems like there are a few more imports to correct: Are you happy to do that @vidakDK, I can do it otherwise? |
Member
|
I was hoping that |
Member
|
Closing this one for Hacktoberfest purposes, thanks @vidakDK! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3.8 from collections import Mutable no longer works, instead
from collections.abc import Mutable must be used