ci: add homebrew release #143
Conversation
zeroshade
requested review from
Mandukhai-Alimaa,
amoeba,
eitsupi,
ianmcook and
lidavidm
|
I haven't created |
amoeba
left a comment
amoeba
left a comment
There was a problem hiding this comment.
Thanks. Looks about right to me. Left two notes.
.goreleaser.yaml
Outdated
| - dbc@{{ .Version }} | ||
| - dbc@{{ .Major }} | ||
| - dbc@{{ .Major }}.{{ .Minor }} |
There was a problem hiding this comment.
| - dbc@{{ .Version }} | |
| - dbc@{{ .Major }} | |
| - dbc@{{ .Major }}.{{ .Minor }} | |
| - dbc@{{ .Version }} | |
| - dbc@{{ .Major }}.{{ .Minor }} |
I think we could totally skip this but at least I don't think we need all three aliases. What do you think about just Major.Minor for now?
There was a problem hiding this comment.
at a minimum we should do Version + Major/Minor
.goreleaser.yaml
Outdated
| description: "A CLI utility for managing ADBC drivers" | ||
| repository: | ||
| owner: "columnar-tech" | ||
| name: "homebrew-dbc" |
There was a problem hiding this comment.
| name: "homebrew-dbc" | |
| name: "homebrew-tap" |
It's slightly more conventional to call the repo "homebrew-tap". That carries the benefit of us not having to rename the repo if we create more formulae/casks.
There was a problem hiding this comment.
Is it? Everything I was seeing was that it should be homebrew-${package} I thought? Though I guess you're right for the case where we might want to create more under the Columnar org...
@ianmcook thoughts?
There was a problem hiding this comment.
I mean: https://github.com/charmbracelet/homebrew-tap. :) but also https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap says it.
There was a problem hiding this comment.
I have no idea, but if the docs say to use homebrew-tap then that seems like a good reason to.
|
Thanks for doing this! |
zeroshade
force-pushed
the
homebrew-tap
branch
from
f011817 to
72b769c
Compare
|
I created |
closes #85