feat(info): add info subcommand #144
Conversation
amoeba
left a comment
amoeba
left a comment
There was a problem hiding this comment.
This looks good. The implementation gets info about the latest version of the driver which is what I think we want. I left one comment about the output which I'm not loving yet and I added the info command to the CLI docs.
cmd/dbc/info.go
Outdated
| } | ||
| case dbc.Driver: | ||
| if isatty.IsTerminal(os.Stdout.Fd()) { | ||
| cmds = append(cmds, tea.EnterAltScreen) |
There was a problem hiding this comment.
Hrm, I'm seeing info open a pager-like interface, I don't like that as a default behavior. Was this intentional?
There was a problem hiding this comment.
yes that was intentional. I was matching the behavior of apt-get info etc. I can remove that pager interface if desired
There was a problem hiding this comment.
removed the pager interface and updated the PR
There was a problem hiding this comment.
Yeah, I think if we want do automatic paging on commands, it should be overall paradigm the CLI uses consistently so it's better to just print normally for now. Thank you!
zeroshade
force-pushed
the
add-info-subcmd
branch
from
0f30b6c to
2e3b434
Compare
closes #82