Conversation
amoeba
reviewed
Mar 9, 2026
Member
amoeba
left a comment
amoeba
left a comment
There was a problem hiding this comment.
I read through the https://github.com/charmbracelet/bubbletea/blob/v2.0.0/UPGRADE_GUIDE_V2.md and then reviewed each file. I then went through each file the changes here look pretty safe.
This does break piping output, I think something with the new NeedsRenderer method is off. For example, when I pipe search output, I now get control codes,
$ dbc search | less
ESC[1;38;5;35mbigqueryESC[m
Other than that, this looks good to me.
| case tea.KeyCtrlC, tea.KeyCtrlD, tea.KeyEsc: | ||
| case tea.KeyPressMsg: | ||
| switch msg.String() { | ||
| case "ctrl+c", "ctrl+d", "esc": |
Member
There was a problem hiding this comment.
This change in bubbletea seems unfortunate. Just noticing.
Member
Author
There was a problem hiding this comment.
yea, that did annoy me a bit.
Use lipgloss.Println instead of fmt.Println for FinalOutput and formatErr so that ANSI escape codes are automatically stripped when stdout is not a terminal (e.g. piping to less or grep). In lipgloss v2, Style.Render() always produces ANSI codes and color stripping is handled by the lipgloss Writer.
Member
Author
|
@amoeba updated to fix the piping output |
amoeba
approved these changes
Mar 11, 2026
Member
amoeba
left a comment
amoeba
left a comment
There was a problem hiding this comment.
Tested and it looks good now, thanks.
zeroshade
added a commit
that referenced
this pull request
Apr 17, 2026
Update to the recently released bubbletea v2 (and corresponding libs like lipgloss and such) see https://github.com/charmbracelet/bubbletea/releases/tag/v2.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the recently released bubbletea v2 (and corresponding libs like lipgloss and such)
see https://github.com/charmbracelet/bubbletea/releases/tag/v2.0.0