fix: restore output for add and remove subcommands, add tests#348
Merged
zeroshade merged 1 commit intocolumnar-tech:mainfrom Apr 7, 2026
Merged
fix: restore output for add and remove subcommands, add tests#348zeroshade merged 1 commit intocolumnar-tech:mainfrom
zeroshade merged 1 commit intocolumnar-tech:mainfrom
Conversation
amoeba
force-pushed
the
fix/dbc-add-not-rendering
branch
from
fadb0ba to
35bfd11
Compare
zeroshade
pushed a commit
that referenced
this pull request
Apr 17, 2026
In our upgrade to bubbletea v2, we didn't catch that we lost the output for dbc add and remove. Whereas dbc 0.2.0 prints like this, ```sh $ dbc add mysql added mysql to driver list use `dbc sync` to install the drivers in the list ``` git main prints like this (nothing): ```sh $ dbc add mysql ``` This patch restores the output and adds regression tests for both subcommands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our upgrade to bubbletea v2, we didn't catch that we lost the output for dbc add and remove. Whereas dbc 0.2.0 prints like this,
git main prints like this (nothing):
This patch restores the output and adds regression tests for both subcommands.