feat: publish dbc to npm#381
Conversation
|
I changed how the npm artifacts are built so as little as possible is checked into the repo. create_package.js now creates the entire file structure, including package.json. This is ready for another review. |
zeroshade
left a comment
There was a problem hiding this comment.
LGTM, my only question is whether there is any ability to add a "snapshot" style dry-run path to the CI somehow (for example, we have --snapshot for goreleaser so that we can ensure via CI that we don't break the release process).
|
I added a step that just creates the npm packages to the |
|
I'm going to test the update to the snapshot job in a separate draft pr before merging just to make sure it works. |
|
Okay, the snapshot job now has a test that actually installs the wrapper package and makes sure the equivalent of |
Adds support for publishing dbc to npm by,
There are two options for shipping dbc on npm,
Option 1 is the only one supported by goreleaser but option 2 is better IMO because we ship the dbc binary in the npm package. This means installation isn't making an extra request to a separate origin and it also means the package can be installed with scripts disabled.
Closes #355