fix: gracefully handle install without signature #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoeba
reviewed
Sep 17, 2025
Member
amoeba
left a comment
amoeba
left a comment
There was a problem hiding this comment.
Thanks for this. Seems fine.
What did you think about maybe removing the partially-installed driver when install fails like this?
| m := InstallCmd{Driver: "test-driver-no-sig"}. | ||
| GetModelCustom(baseModel{getDriverList: getTestDriverList, downloadPkg: downloadTestPkg}) | ||
| out := suite.runCmdErr(m) | ||
| suite.Contains(out, "signature file 'test-driver-1-not-valid.so.sig' for driver is missing") |
Member
There was a problem hiding this comment.
Should we test the state of the tmpdir after failure so we know what files remain when install fails? It'd be good as a regression test if we change the behavior.
Member
Author
There was a problem hiding this comment.
Should I make the change in this PR to clean up after the failed install?
zeroshade
force-pushed
the
install-no-signature
branch
from
19006f3 to
e59d618
Compare
amoeba
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
MANIFESTis missing theFiles.signaturethen we first try looking fordriver + '.sig'and then error out.Adds a new CLI argument
--allow-missing-signaturewhich will allow installing if the signature is missing.