Merged
Conversation
mafrahm
approved these changes
Nov 13, 2025
Contributor
mafrahm
left a comment
There was a problem hiding this comment.
LGTM, just one question for my own understanding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In awkward, arrays that are the result of a mask being applied to a larger array are not copies. They appear to have a shorter length (in the desired dimension) but internally, they still seem to reference the original, unmodified data (as can be seen when printing the number of bytes via
array.nbytes, which still reflects the original value).Using these arrays in
ak.concatenateoperations results in the original data being concatenated as well, which is undesired in most use cases in cf as it needlessly leads to excessive memory footprints.Wrapping these masked arrays by
ak.Arrayorak.copydoes not apply the initial mask, but just returns a view or full copy of the array (which, again, still contains a reference to the unmodified data). Onlyak.to_packedfully resolves masks (in addition to yet un-materialized columns, which it was originally intended for). Fortunately, it does not copy arrays that are already fully materialized.This PR adds a util
ak_concatenate_safethat does the same asak.concatenate, but wraps each input array byak.to_packed, avoiding all the aforementioned issues.