ScalaJs 1.0.0-M1 support #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
force-pushed
the
sjs1.0.0-M1
branch
2 times, most recently
from
3cfb9fd to
0ec08fa
Compare
Collaborator
Contributor
Author
|
Hi @olafurpg please double check this! |
olafurpg
approved these changes
Jul 11, 2017
Collaborator
olafurpg
left a comment
olafurpg
left a comment
There was a problem hiding this comment.
Just double-checked locally, LGTM 👍 Although it's a shame that we have to exit sbt to cross-build sjs.
The sourcecode built matrix will soon grow larger than the library sources!
Collaborator
|
sourcecode 0.1.4 for sjs 1.0.0-M1 is its way to maven central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.