perf(plugins): optimize highlight to use codeToTokens fast path to skip hast intermediary#170
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
comark
@comark/ansi
@comark/html
@comark/nuxt
@comark/react
@comark/svelte
@comark/vue
commit: |
farnabaz
approved these changes
Apr 29, 2026
Contributor
farnabaz
left a comment
There was a problem hiding this comment.
Comark used to use code to tokens at first but in order to support transformers we moved to code to hast.
Switching between these two based on transformers existence is smart move 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
this PR optimizes the highlight plugin further by using shiki's
codeToTokensAPI directly instead ofcodeToHastwhen no transformers are configured. this skips the entire hast tree construction and the subsequenthast => ComarkNodeconversion, building ComarkNodes directly from the flat token array in a single pass📝 Checklist
pnpm verifyand it passes.