fix(highlight): stop injecting tabindex="0" on pre blocks#239
Merged
Conversation
The highlight plugin hardcoded tabindex="0" on every <pre> block, polluting output for all consumers. Remove it and let user-supplied tabindex round-trip back to markdown instead of being dropped.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
benjamincanac
changed the title
tabindex="0" on highlighted pre blocks
benjamincanac
changed the title
tabindex="0" on highlighted pre blockstabindex="0" on pre blocks
comark
@comark/ansi
@comark/html
@comark/nuxt
@comark/react
@comark/svelte
@comark/vue
commit: |
farnabaz
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
The highlight plugin hardcoded
tabindex="0"on every<pre>block, so it leaked into the output of every consumer whether they wanted it or not.tabindex: '0'injection inhighlightCodeBlocks(packages/comark/src/plugins/highlight.ts).tabindexfrom thepreimplicit-drop list inattributes.tsso a genuine user-supplied{tabindex="0"}now round-trips back to markdown instead of being silently stripped.stylestays dropped since it's still injected bypreStyles.All
pnpm testpass (1064 tests).📝 Checklist
pnpm verifyand it passes.