test(spec): use parsed AST to detect keys order mismatch#37
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
atinux
approved these changes
Mar 6, 2026
farnabaz
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SPEC tests for HTML and Markdown rendering were using the stored AST snapshot instead of the actual
parse()output. Since toEqual ignores key order, ordering mismatches betweenparse()and the snapshot went undetectedThe AST test passed, but the rendering tests never saw what
parse()really produced.Fix: move
parse()into a beforeAll shared across all blocks, so HTML and Markdown are rendered from the actual parse output.This exposed stale snapshots in 6 SPEC files (wrong attribute order in HTML, wrong key order in frontmatter, duplicate key in AST) which are corrected in this PR.