Conversation
…sionsTest RequiredPermissionsTest used factory.manufacturePojo() directly which generates random projectId/projectName values. Since OPIK-4931 added project resolution that returns 404 for non-existent projects, these tests fail at dataset/prompt creation before reaching permission checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
java
Contributor
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
TS SDK E2E Tests - Node 18236 tests 234 ✅ 15m 33s ⏱️ Results for commit c947ea2. |
Contributor
Contributor
Python SDK E2E Tests Results (Python 3.10)244 tests ±0 242 ✅ ±0 8m 5s ⏱️ -11s Results for commit c947ea2. ± Comparison against base commit 9009203. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
Contributor
Contributor
Python SDK E2E Tests Results (Python 3.13)244 tests ±0 242 ✅ ±0 8m 29s ⏱️ +18s Results for commit c947ea2. ± Comparison against base commit 9009203. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
Contributor
Python SDK E2E Tests Results (Python 3.14)244 tests ±0 242 ✅ ±0 8m 14s ⏱️ -4s Results for commit c947ea2. ± Comparison against base commit 9009203. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
Contributor
Python SDK E2E Tests Results (Python 3.11)244 tests ±0 242 ✅ ±0 8m 5s ⏱️ -2s Results for commit c947ea2. ± Comparison against base commit 9009203. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
Contributor
Python SDK E2E Tests Results (Python 3.12)244 tests ±0 242 ✅ ±0 8m 11s ⏱️ +4s Results for commit c947ea2. ± Comparison against base commit 9009203. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
andrescrz
approved these changes
Mar 17, 2026
andrescrz
deleted the
aliakseivinahradau/NA-fix-required-permissions-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fix failing
RequiredPermissionsTesttests inDatasetsResourceTestandPromptResourceTest.How this broke: Semantic merge conflict between two PRs that touched different lines but had conflicting semantics:
projectId/projectNamefields to Dataset/Prompt and returns 404 for non-existent projectsRequiredPermissionsTestusingfactory.manufacturePojo()which now generates randomprojectIdvaluesNeither PR was broken individually. Git merged them cleanly (no textual conflicts), but
manufacturePojo()now generates a randomprojectIdthat doesn't exist, causing 404 at entity creation before reaching the permission check.Fix: Use
buildDataset()/buildPrompt().build()helpers that null outprojectId/projectName.Change checklist
Issues
Testing
DatasetsResourceTest$RequiredPermissionsTest— 4 tests (3 previously failing)PromptResourceTest$RequiredPermissionsTest— 2 tests (2 previously failing)Documentation
N/A