fix: Amend behaviour of ambient video control button#871
fix: Amend behaviour of ambient video control button#871curlyfriesplease merged 4 commits intomasterfrom
Conversation
AndyEPhipps
left a comment
There was a problem hiding this comment.
Very nice, swanky improvement
It does make me wish for a CSS property for "currently visible in viewport" to completely close the loop (so here, the button wouldn't be hidden prematurely when offscreen), but still seems to be in the realm of crummy JS for the moment 😮💨
I think that could be done in JS with the Intersection Observer. Never used it myself but saw a talk on it once and it looks like a handy thing |
|
Gah. It won't publish likely because the auto-publish rule ignores certain semantic PR prefixes. |
|
🎉 This PR is included in version 8.71.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PR description
What is it doing?
Two amendments to the behaviour of play/pause button for ambient video, following Curtis' review:
Why is this required?
Design QA
link to Jira ticket:
ENG-5006
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...