Skip to content

fix: Amend behaviour of ambient video control button#871

Merged
curlyfriesplease merged 4 commits intomasterfrom
ENG-5006-hover-increase
Apr 15, 2026
Merged

fix: Amend behaviour of ambient video control button#871
curlyfriesplease merged 4 commits intomasterfrom
ENG-5006-hover-increase

Conversation

@curlyfriesplease
Copy link
Copy Markdown
Contributor

@curlyfriesplease curlyfriesplease commented Apr 15, 2026

PR description

What is it doing?

Two amendments to the behaviour of play/pause button for ambient video, following Curtis' review:

  1. Increase fadeout from 2s to 3s
  2. Make the button appear on initial load, so the user knows it's there

Why is this required?

Design QA

link to Jira ticket:

ENG-5006

Quick Checklist:

  • My PR title follows the Conventional Commit spec.

  • I have filled out the PR description as per the template above.

  • I have added tests to cover new or changed behaviour.

  • I have updated any relevant documentation.

Important! - lastly, make sure to squash merge...

@curlyfriesplease curlyfriesplease changed the title Increase play pause button fadeout from 2s to 3s refactor: Amend behaviour of ambient video control button Apr 15, 2026
Copy link
Copy Markdown
Contributor

@AndyEPhipps AndyEPhipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, swanky improvement

It does make me wish for a CSS property for "currently visible in viewport" to completely close the loop (so here, the button wouldn't be hidden prematurely when offscreen), but still seems to be in the realm of crummy JS for the moment 😮‍💨

@curlyfriesplease
Copy link
Copy Markdown
Contributor Author

Very nice, swanky improvement

It does make me wish for a CSS property for "currently visible in viewport" to completely close the loop (so here, the button wouldn't be hidden prematurely when offscreen), but still seems to be in the realm of crummy JS for the moment 😮‍💨

I think that could be done in JS with the Intersection Observer. Never used it myself but saw a talk on it once and it looks like a handy thing
Not going down that rabbithole today unless there is further Design QA in that regard!

@curlyfriesplease curlyfriesplease merged commit 9c93c82 into master Apr 15, 2026
9 checks passed
@curlyfriesplease curlyfriesplease deleted the ENG-5006-hover-increase branch April 15, 2026 12:54
@curlyfriesplease curlyfriesplease restored the ENG-5006-hover-increase branch April 15, 2026 13:26
@curlyfriesplease
Copy link
Copy Markdown
Contributor Author

Gah. It won't publish likely because the auto-publish rule ignores certain semantic PR prefixes.
Going to retitle this as "fix: etc" and try again

@curlyfriesplease curlyfriesplease changed the title refactor: Amend behaviour of ambient video control button fix: Amend behaviour of ambient video control button Apr 15, 2026
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 8.71.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants