fix: email is null bug

Author: s-barrah

src/Model/SQS/MarketingPreference.model.js

@@ -465,7 +465,7 @@ export default class MarketingPreference extends Model {
       if ((this.getPermissionEmail() !== null
         && this.getPermissionEmail() !== ''
         && this.getPermissionEmail() !== '0')
-      || this.getEmail() !== '') {
+      || (this.getEmail())) {
         if (this.getEmail()) {
           requestConstraintsClone.email = { email: true };
         } else {

tests/unit/Model/SQS/MarketingPreferences.model.js

@@ -239,27 +239,27 @@ describe('Model/MarketingPreferencesModel', () => {
 
   describe('Ensure validation passes when permissions are not set', () => {
     const mockedData = {
-      firstname: 'Tim',
-      lastname: 'Jones',
+      firstname: 'Kelvin',
+      lastname: 'James',
       phone: '0208 254 3062',
-      mobile: '07917 321 492',
-      address1: '32-36',
-      address2: 'St. Smith\'s Avenue',
-      address3: '',
-      town: 'London',
-      postcode: 'sw184bx',
-      country: 'United Kindgom',
-      campaign: 'sr18',
+      mobile: '07425253522',
+      address1: 'COMIC RELIEF',
+      address2: 'CAMELFORD HOUSE 87-90',
+      address3: 'ALBERT EMBANKMENT',
+      town: 'LONDON',
+      postcode: 'SE1 7TP',
+      country: 'GB',
+      campaign: 'RND19',
       transactionId: 'AN129MNDJDJ',
-      transSource: 'giftaid-sportrelief',
+      transSource: 'RND19_GiftAid',
       transSourceUrl: 'https://giftaid.sportrelief.com/',
       transType: 'prefs',
-      email: '',
-      permissionEmail: '',
-      permissionPost: '',
-      permissionPhone: '',
-      permissionSMS: '',
-      timestamp: '1550841771',
+      confirm: 1,
+      permissionEmail: null,
+      permissionPost: null,
+      permissionPhone: null,
+      permissionSMS: null,
+      timestamp: '1562165588',
     };
 
     const model = new MarketingPreferencesModel(mockedData);