feat: Add getters for headers#111
Merged
Merged
Conversation
seb-cr
force-pushed
the
108-add-getters-for-headers
branch
from
a9d3d16 to
e020a3e
Compare
dipasqualew
reviewed
Oct 29, 2020
Contributor
dipasqualew
left a comment
dipasqualew
left a comment
There was a problem hiding this comment.
That's great work, having those shortcuts greatly lowers the complexity of other functions. Thanks! I left a couple of minor notes
dipasqualew
previously approved these changes
Oct 29, 2020
seb-cr
force-pushed
the
108-add-getters-for-headers
branch
from
09ad78c to
3d3961e
Compare
dipasqualew
approved these changes
Oct 29, 2020
Contributor
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new methods to
RequestService:getAllHeaders(): shortcut forrequest.getContainer().getEvent().headersgetHeader(name, default=''): get a header value using a case-insensitive searchSome of the existing code can then be significantly improved using
getHeader.