Conversation
corinja
approved these changes
May 2, 2024
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
seb-cr
added a commit
that referenced
this pull request
Jul 24, 2024
Replaces some of the harder-to-understand use of callback-style async and `new Promise` with simpler async-await. As a bonus, we can remove the `async` dependency! This also fixes a bug in `SQSService#checkStatus`, where a failed `listQueues` call can result in a `TypeError` if the `data` parameter of the callback is undefined or null. Previously the unit tests ignored this by passing an empty object (see the deleted `createCallbackMock` function). No specific Jira ticket, but removal of `async` completes [ENG-3212] (Note at time of merge: a substantial amount of the callback-style async calls to AWS APIs were already replaced with Promise chains when we migrated to AWS SDK v3 in #1201. I've preserved the original commit message, but it is no longer completely accurate!) [ENG-3212]: https://comicrelief.atlassian.net/browse/ENG-3212
seb-cr
added a commit
that referenced
this pull request
Jan 27, 2025
This has been broken since upgrading to AWS SDK v3 (#1201). The object body is no longer returned as a `Buffer` but as a `Readable`. Jira: [ENG-3796]
seb-cr
added a commit
that referenced
this pull request
Jan 29, 2025
`BaseConfigService` has been broken since upgrading to AWS SDK v3 (#1201). - The S3 object body is no longer returned as a `Buffer`, but as a `StreamingBlobPayloadOutputTypes` - Errors now have a capitalised `Code` key, which impacts handling of missing config objects Jira: [ENG-3796] [ENG-3796]: https://comicrelief.atlassian.net/browse/ENG-3796
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS SDK v2 will enter maintenance mode in September and will become unmaintained in 2025, as announced here.
Documentation for AWS SDK v3 can be found here, however it is often not particularly helpful unless you know exactly what you're looking for. This upgrade guide is helpful for filling in some of the gaps.
This upgrade should not introduce behavioural changes. It removes the peer dependency on
aws-sdk, and I've added the new AWS SDK packages as direct dependencies instead. This will make the update process as simple as possible (we're still using v2 in most of our services) and adding new peer dependencies would create a breaking change.Jira: ENG-3211