Skip to content

Migrate to null safety#14

Merged
comigor merged 5 commits intocomigor:masterfrom
anirudhb:null-safety
Jan 8, 2021
Merged

Migrate to null safety#14
comigor merged 5 commits intocomigor:masterfrom
anirudhb:null-safety

Conversation

@anirudhb
Copy link
Copy Markdown
Contributor

Migrates the fuzzy library to null safety. There are now no dependencies. package:meta is obsolete due to the introduction of the required keyword, and package:latinize seemed to have a dead repo so I just put its code here (so that it is null safe.)

I would really like if this null safety prerelease could be published quickly on pub.dev, I'd like to use it for one of my projects. Thanks for making this great library as always!

@anirudhb
Copy link
Copy Markdown
Contributor Author

n.b. tests are failing since the container uses flutter stable, which only has dart 2.10 (NNBD is enabled in 2.12-dev, which is only available on dev/master IIRC)

@comigor
Copy link
Copy Markdown
Owner

comigor commented Jan 4, 2021

Hello @anirudhb, thank you so much for this PR (and sorry for the late reply)!
I'll fix the pipeline and take a look at this soon

* origin/master:
  Bump pubspec version
  Bump version and add changelog
  Fix tests types
  Fix analyzer issues
  Use flutter beta branch
  Fix linter
  OMG
  Bump dependencies, fix CI
  Improve weighted search results when there is a single key
  Add an option to ignore tokens smaller than a length when searching
  Add normalization on key weights in FuzzyOptions
  Change condition on _computeScore to combine the scores from all keys
  Add tests to check that weighted search considers all keys in the score
  Fix bug where the token score average was ignored in the result score
  Fixes bug where search always returned arrayIndex = -1
  Bump version and add changelog
  Ignore empty tokens after tokenizing the query pattern
  Add tests for when the query pattern starts or ends with the tokenSeparator
@comigor
Copy link
Copy Markdown
Owner

comigor commented Jan 8, 2021

I've updated latinize and migrated it to nullsafety, and merged this PR with master.
We just need to wait for latinize pipeline to be fixed and it should be good to go!

@comigor comigor merged commit f4135f6 into comigor:master Jan 8, 2021
@comigor
Copy link
Copy Markdown
Owner

comigor commented Jan 8, 2021

@anirudhb Thanks for the help, it was released as 0.4.0-nullsafety.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants