Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comma three: correctly set initial EPS bearer settings for AT&T sim cards #24175

Merged
merged 4 commits into from
Apr 11, 2022

Conversation

adeebshihadeh
Copy link
Contributor

No description provided.

@pd0wm
Copy link
Contributor

pd0wm commented Apr 9, 2022

  • Is the modem online at this point? Try setting prebuilt.
  • We can check the sim id and only do the changes for AT&T sims.

@adeebshihadeh adeebshihadeh marked this pull request as draft April 11, 2022 04:00
@adeebshihadeh adeebshihadeh marked this pull request as ready for review April 11, 2022 22:24
@pd0wm pd0wm changed the title improved tici modem config comma three: correctly set initial EPS bearer settings for AT&T sim cards Apr 11, 2022
@adeebshihadeh adeebshihadeh merged commit c138863 into master Apr 11, 2022
@adeebshihadeh adeebshihadeh deleted the sunset branch April 11, 2022 22:33
budney pushed a commit to budney/openpilot that referenced this pull request Apr 12, 2022
…ards (commaai#24175)

* 3g sunset

* only for blue prime

* pass

* full att code

Co-authored-by: Comma Device <device@comma.ai>
adeebshihadeh added a commit that referenced this pull request Apr 15, 2022
…ards (#24175)

* 3g sunset

* only for blue prime

* pass

* full att code

Co-authored-by: Comma Device <device@comma.ai>
adeebshihadeh added a commit that referenced this pull request Apr 15, 2022
* Log modem version and some NV values (#24137)

* add back modem version number logging

* tici only

* log nv

* make event

* str cast

* comma three: correctly set initial EPS bearer settings for AT&T sim cards (#24175)

* 3g sunset

* only for blue prime

* pass

* full att code

Co-authored-by: Comma Device <device@comma.ai>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
sshane pushed a commit to sshane/openpilot that referenced this pull request Apr 21, 2022
* Log modem version and some NV values (commaai#24137)

* add back modem version number logging

* tici only

* log nv

* make event

* str cast

* comma three: correctly set initial EPS bearer settings for AT&T sim cards (commaai#24175)

* 3g sunset

* only for blue prime

* pass

* full att code

Co-authored-by: Comma Device <device@comma.ai>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants