Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKG: Car Port for Hyundai Palisade and Kia Telluride 2023-24 (HDA2) #27392

Closed
wants to merge 191 commits into from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Feb 19, 2023

Checklist

Link to all physical parts during installation

Software URL

Requires

Resolves

Related

Thanks to community Hyundai Palisade 2023 owner yumybraun and Kia Telluride 2023 owner kjanoudi.

…t-new

# Conflicts:
#	opendbc
#	panda
#	selfdrive/car/hyundai/carcontroller.py
#	selfdrive/car/hyundai/carstate.py
#	selfdrive/car/hyundai/values.py
#	selfdrive/car/torque_data/override.yaml
# Conflicts:
#	opendbc
#	panda
#	selfdrive/car/hyundai/carcontroller.py
#	selfdrive/car/hyundai/carstate.py
@sunnyhaibin
Copy link
Contributor Author

Upon investigation, LKAS11 | 0x340 broadcasts on bus 4, and we were unable to send steering commands to this message as we were not able to intercept. We will need to find another steering message that we can use.

@Guardiola31337
Copy link

Hey @sunnyhaibin thanks for bringing support to these cars! I'm an owner of a Kia Telluride 2023 and I'd love to test. May I ask why you have mark the harness with a warning?

Kia Telluride 2023: Hyundai L ⚠️

Please let me know if I can help with any testing, happy to!

@sunnyhaibin
Copy link
Contributor Author

Hey @sunnyhaibin thanks for bringing support to these cars! I'm an owner of a Kia Telluride 2023 and I'd love to test. May I ask why you have mark the harness with a warning?

Kia Telluride 2023: Hyundai L ⚠️

Please let me know if I can help with any testing, happy to!

I forgot to update it. The harness for 2023 Telluride should be Harness P. Updated the description.

@Guardiola31337
Copy link

Yeah, I've just seen 👍

Thanks for confirming!

@sunnyhaibin
Copy link
Contributor Author

Proof that it works 🎉 Route with raw logs will be added to routes.py once all raw logs are uploaded.

Upload.from.GitHub.for.iOS.MOV

@sshane
Copy link
Contributor

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

@sshane sshane closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants