fix: use resolvable Ajv 2020 ESM import path#45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ajv/dist/2020is not resolvable in ESM environments by using the explicit ESM file path.Description
import Ajv2020 from "ajv/dist/2020";withimport Ajv2020 from "ajv/dist/2020.js";insrc/trust.tsand leave all validation logic unchanged; the only modified file issrc/trust.ts.Testing
npm install, which failed with a403 Forbiddenerror when fetchingajv, so dependencies were not installed.npm run build, which failed due to missing dependencies/types caused by the install failure (TypeScript errors for missingajv,ajv-formats, and Node types).npm test, which failed becausepretestrunsnpm run build, and the build failed for the same reason.Codex Task