fix(auth): align SIWE statement and surface verify errors#268
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
SIWE_STATEMENT = 'Authenticate with CommandLayer Claim activation.'inpublic/claim.htmland used it when constructing the SIWE message so the signed statement is exact.signInWithEthereumto throw and displaySIWE verification failed: <error> — <reason>when/api/auth/verifyreturns structured failure details.api/auth/verify.jsto enforce the exactREQUIRED_STATEMENT, accept configurable allowlists viaCOMMANDLAYER_SIWE_DOMAINSandCOMMANDLAYER_SITE_URLS(with sensible defaults forwww.commandlayer.org, optionalcommandlayer.org, and localhost in development), and validate normalized URIs and chain IDs.AUTH_FAILEDJSON payloads and stable error codes and reasons (includingmissing_message,missing_signature,dependency_unavailable,malformed_message,domain_mismatch,uri_mismatch,chain_not_allowed,statement_mismatch, andsignature_invalid).tests/api-auth.test.jsto assert the new error codes and added a statement-mismatch test path.Testing
npm testin the repository and all tests passed (31passing tests).npm run buildbut abuildscript is not defined in this repo (noted in validation).cd examples/webhook-auto-verify && npm install && npm run checkand the example checks succeeded.Codex Task