Normalize DB query results and fix admin claims for Neon direct-array responses#300
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@neondatabase/serverlessbecause Neon can return a direct-array result shape instead of the{ rows }shape returned by pg clients.{ rows: [...] }and Neon direct-array responses to prevent regressions and enable safe non-production debug data.Description
normalizeQueryResult()andnormalizeRows()tolib/db.jsand madequery()always return a{ rows }shape by normalizing Neon direct-array results.api/admin/claims.jsto usedb.normalizeRows(result)for mapping claims and to include a safedebugobject only whenNODE_ENV !== 'production'.api/admin/claim.jsto normalize claim/agent/event query results withdb.normalizeRows(...)and to include the same safe non-production debug payload on failure.tests/api-admin-claims.test.jsto mock both pg-style and Neon direct-array query responses for list and detail endpoints and updated the test DB loader to providenormalizeRowsduring tests.Testing
npm testand all tests passed (69tests passed,0failed).cd examples/webhook-auto-verify && npm run checkand the example checks completed successfully.tests/api-admin-claims.test.jsthat exercise both{ rows: [...] }and direct-array results and they succeeded under the test runs.Codex Task