fix: handle Coinbase webhook post-verification crashes gracefully#301
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FUNCTION_INVOCATION_FAILEDinstead of a JSON error response.signReceiptcan throw on invalid key material or unsupported event shapes.Description
normalizeReceiptinapi/examples/coinbase-webhook.jsto reject non-object payloads and missing/non-stringid|event_idortype, throwing a sentinel error for unsupported shapes.try/catchthat maps the sentinel error to400 normalization_failedand other errors to503 signing_unavailable, preserving successful signing behavior.eventIdcheck to return400 normalization_failedfor consistency with the new normalization guard.Testing
tests/api-coinbase-webhook.test.jsfor invalid base64/PEM signing key (expects503 signing_unavailable) and malformed event shape after valid HMAC (expects400 normalization_failed).npm testand all tests passed:69 passed, 0 failed.Codex Task