Normalize Coinbase receipt signing key parsing to support existing runtime formats#304
Merged
GsCommand merged 1 commit intoMay 23, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
signing_unavailablebecause the runtime signing key stored inRECEIPT_SIGNING_PRIVATE_KEY_PEM_B64used an existing runtime encoding that the signer code did not normalize.Description
lib/receiptSigning.jsto accept raw full PEM,base64(full PEM), raw PEM body only,base64(PEM body), and literal"\n"sequences and to wrap bare bodies into 64-char PEM lines.BEGIN PRIVATE KEY/END PRIVATE KEYuse it, otherwise wrap the body without mutating environment variables.RECEIPT_SIGNING_PRIVATE_KEY_PEM_B64) and did not change Coinbase HMAC verification or other unrelated files.lib/receiptSigning.js(normalization logic) andtests/receiptSigning.test.js(new tests).Testing
tests/receiptSigning.test.jswhich verifies the existing runtime-compatibleRECEIPT_SIGNING_PRIVATE_KEY_PEM_B64style,base64(full PEM), raw PEM body handling, and the invalid-key safe path.npm testand all tests passed (76 tests, 0 failures).Codex Task