Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
purchase.receiptschema that referenced a missing$defsentry.payment_requirement,payment_session, andpayment_proof.$defsto prevent future copy/paste errors.Description
schemas/v1.1.0/commercial/purchase/purchase.receipt.schema.jsonby restoring the missingsettlement$defs(copied from the canonical checkout receipt shape) and replacing the one-offx402_proofname with a canonicalpayment_proofdefinition wired to the existing current-line shape, preserving requiredpayment_proofsemantics forstatus: capturedreceipts.scripts/validate-all.mjsto: enforce exact equality for duplicated canonical$defslisted inCANONICAL_DEF_NAMES; addPAYMENT_ALIAS_GROUPSchecks that compare payment-layer alias defs (e.g.payment_proofvsx402_proof); and assert that legacy TypeScript example directories do not appear under the current-lineexamples/v1.1.0/**/tstree.examples/v1.1.0/commercial/*/ts/to avoid an unvalidated parallel example surface and updated docs to state that current-line TS examples are excluded unless explicitly validated and governed.checksums.txtso the checksum ledger matches the repaired shipped bytes; the only checksum-covered artifact that changed wasschemas/v1.1.0/commercial/purchase/purchase.receipt.schema.json(new SHA-256:e4613661a5764379d0512d5b6ee05c8862089d30fc1e134694df045172019e45).README.mdandONBOARDING.mdclarifying thatvalidate:exampleschecks JSON examples and that TypeScript example directories are excluded from the authoritative current-line surface.Testing
npm run validate:schemasand it succeeded (schema tree, ids, and canonical$defschecks passed). ✅npm run validate:examplesand all current-line JSON examples validated (authorize/checkout/purchase/ship/verify). ✅npm run generate:checksumswhich wrote 37 checksum rows and updatedchecksums.txt. ✅sha256sum -c checksums.txtand all checksum targets verified ok. ✅npm run validate(which composes the above) and it completed successfully. ✅Codex Task