Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
authorize,checkout,purchase,ship, andverifyso the repo reads as one protocol rather than a set of ad-hoc schemas.shipclearly settlement-adjacent (fulfillment tied to an upstream commercial transaction) and liftpurchaseto be a first-class, well-evidenced one-step contract.Description
$defsforactor_identityplus role-constrained aliases (payer_actor,payee_actor,merchant_actor,provider_actor,carrier_actor,verifier_actor) and replaced loose actor refs with these role-specific refs across all v1.1.0 commercial schemas.payment_requirement(pre-payment),payment_session(live session), andpayment_proof(final evidence), and aligned request/receipt fields and reference enums to use these names consistently.purchaseinto a deliberate one-step contract by adding itemizeditems,amount_breakdown,payment_input(accepting requirement/session/proof refs), normalized receipt statuses tocaptured/failed/pending, and requiringpayment_proofon captured receipts.shipsemantics by makingfulfillment_refa typedfulfillmentartifact, requiring an upstreamcommercial_ref(must becheckoutorpurchase), addingpayerlinkage, and strengthening evidence rules sotracking_urlis required whentracking_numberis present, active states requirecarrier+tracking, anddeliveredrequiresdelivered_atanddelivery_proof_ref.authorize,checkout, andverifyto the same actor/payment grammar (e.g.,authorizeemitspayment_requirement_ref/ authorizationpayment_proof,checkoutandpurchaserequirepayment_proofon capture,verifyacceptspayment_proofandfulfillmenttargets).README.md,SPEC.md,POLICY.md,manifest.json, andchecksums.txtto document and reflect the new grammar and to teach the unified model.Testing
npm run validateto compile schemas and validate the current v1.1.0 line, and it completed successfully.npm run validate:examplesto validate all current-line examples against the updated schemas, and it completed successfully.npm run generate:checksumsand updatedchecksums.txt, and the checksums generation succeeded.Codex Task